fix(xxx-intl): replace misused EventEmitter with Subject #6313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://angular.io/api/core/EventEmitter#description, EventEmitter is not for services. And Subject is preferrable.
googlebot
added
the
cla: yes
e-cloud
force-pushed
the
fix/misued-eventemitter
branch
from
d684875
to
6459ca5
Compare
e-cloud
force-pushed
the
fix/misued-eventemitter
branch
from
6459ca5
to
5c41c3a
Compare
willshowell
reviewed
Aug 7, 2017
| @@ -6,7 +6,8 @@ | |||
| * found in the LICENSE file at https://angular.io/license | |||
| */ | |||
|
|
|||
| import {Injectable, EventEmitter} from '@angular/core'; | |||
| import {Injectable} from '@angular/core'; | |||
| import { Subject } from 'rxjs/Subject'; | |||
There was a problem hiding this comment.
As a heads up, they'll want you to remove these spaces. Here and below.
There was a problem hiding this comment.
that's ok. however, it's better to apply a tool like prettier that format the code at pre-commit. That would be more efficient on code style management.
|
The tests should be fine, there is something wrong with travis. |
mmalerba
approved these changes
Aug 8, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://angular.io/api/core/EventEmitter#description, EventEmitter is not for services. And Subject is preferrable.