Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xxx-intl): replace misused EventEmitter with Subject #6313

Merged
merged 3 commits into from
Aug 8, 2017
Merged

fix(xxx-intl): replace misused EventEmitter with Subject #6313

merged 3 commits into from
Aug 8, 2017

Commits on Aug 7, 2017

  1. fix(xxx-intl): replace misused EventEmitter with Subject 

    According to https://angular.io/api/core/EventEmitter#description, EventEmitter is not for services. And Subject is preferrable.
    @e-cloud
    e-cloud committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    5069a69 View commit details
    Browse the repository at this point in the history

  2. test(xxx-intl): update the related tests

    @e-cloud
    e-cloud committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    5c41c3a View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2017

  1. refactor: remove spaces

    @e-cloud
    e-cloud committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    bd26edf View commit details
    Browse the repository at this point in the history