Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Focus still on "open dialog" button after clicked #5713

Closed
xuanshenbo opened this issue Jul 13, 2017 · 1 comment · Fixed by #5769
Closed

Bug: Focus still on "open dialog" button after clicked #5713

xuanshenbo opened this issue Jul 13, 2017 · 1 comment · Fixed by #5769
Assignees
@crisbeto

Comments

@xuanshenbo
Copy link

xuanshenbo commented Jul 13, 2017 •
edited

Bug, feature request, or proposal:

Bug

What are the steps to reproduce?

Use the doc site example: https://material.angular.io/components/dialog/examples
Set focus on the "Launch dialog" button, and hit Enter key multiple times as fast as you can, multiple dialogs will show

What is the expected behavior?

Only one dialog should show

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular Material 2.0.0-beta.8

Is there anything else we should know?

The reason obviously is because the dialog is not yet initiated immediately after hitting Enter , therefore focus is still on the button. Not sure how we can resolve this.
@rafaelss95 rafaelss95 mentioned this issue Jul 13, 2017
Closed
@crisbeto crisbeto self-assigned this Jul 14, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 14, 2017
@crisbeto
fix(dialog): prevent dialog from opening while another dialog is anim…
14e3595 
…ating

Prevents dialogs from being opened while other dialogs are animating.

Fixes angular#5713.
@crisbeto crisbeto mentioned this issue Jul 14, 2017
Merged
kara pushed a commit that referenced this issue Jul 19, 2017
@crisbeto @kara
fix(dialog): prevent dialog from opening while another dialog is anim…
8442054 
…ating

Prevents dialogs from being opened while other dialogs are animating.

Fixes #5713.
kara pushed a commit that referenced this issue Jul 20, 2017
@crisbeto @kara
fix(dialog): prevent dialog from opening while another dialog is anim…
4efef12 
…ating

Prevents dialogs from being opened while other dialogs are animating.

Fixes #5713.
andrewseguin pushed a commit that referenced this issue Jul 24, 2017
@crisbeto @andrewseguin
fix(dialog): prevent dialog from opening while another dialog is anim…
af803fe 
…ating

Prevents dialogs from being opened while other dialogs are animating.

Fixes #5713.
andrewseguin pushed a commit that referenced this issue Jul 25, 2017
@crisbeto @andrewseguin
fix(dialog): prevent dialog from opening while another dialog is anim…
9ab5519 
…ating

Prevents dialogs from being opened while other dialogs are animating.

Fixes #5713.
andrewseguin pushed a commit that referenced this issue Jul 25, 2017
@crisbeto @andrewseguin
fix(dialog): prevent dialog from opening while another dialog is anim…
36f708c 
…ating (#5769)

Prevents dialogs from being opened while other dialogs are animating.

Fixes #5713.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dialog): prevent dialog from opening while another dialog is animating crisbeto/material2
2 participants
@crisbeto @xuanshenbo