Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dialog): prevent dialog from opening while another dialog is animating #5769

Merged
merged 1 commit into from
Jul 25, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 14, 2017

Prevents dialogs from being opened while other dialogs are animating.

Fixes #5713.

Note: I wasn't able to write a test that properly captures the issue that this is solving (I tried using the BrowserAnimationsModule instead of the noop module as well). In unit tests, it seems like the callbacks are fired immediately, whereas we have the animations disabled in the e2e tests in general.

…ating

Prevents dialogs from being opened while other dialogs are animating.

Fixes angular#5713.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 14, 2017
@@ -91,11 +91,19 @@ export class MdDialog {
*/
open<T>(componentOrTemplateRef: ComponentType<T> | TemplateRef<T>,
config?: MdDialogConfig): MdDialogRef<T> {

const inProgressDialog = this._openDialogs.find(dialog => dialog._isAnimating());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it's worthwhile to key this on the component as well? E.g., if I try to open(UserProfile) multiple times in a row, they get blocked, but if I try to open(UserProfile) and open(AdminSettings) at the same time then they both open?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see how that would be useful, but it's probably too much trouble. There's only a 400ms window after you open a dialog where this can happen.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with this for now and see if we get any feedback.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 17, 2017
@andrewseguin andrewseguin merged commit 36f708c into angular:master Jul 25, 2017
crisbeto added a commit to crisbeto/material2 that referenced this pull request Oct 26, 2017
The behavior where we don't allow new dialogs to be opened while a dialog is animating was introduced initially in angular#5769 to avoid issues where the user might open multiple dialogs by accident if they press enter one too many times. This is problematic because it also means that the consumer is blocked from opening dialogs for certain 300ms intervals. These changes approach the issue differently by moving focus onto the dialog container immediately while it's animating.

Fixes angular#5769.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Oct 28, 2017
The behavior where we don't allow new dialogs to be opened while a dialog is animating was introduced initially in angular#5769 to avoid issues where the user might open multiple dialogs by accident if they press enter one too many times. This is problematic because it also means that the consumer is blocked from opening dialogs for certain 300ms intervals. These changes approach the issue differently by moving focus onto the dialog container immediately while it's animating.

Fixes angular#6560.
andrewseguin pushed a commit that referenced this pull request Nov 2, 2017
…8051)

The behavior where we don't allow new dialogs to be opened while a dialog is animating was introduced initially in #5769 to avoid issues where the user might open multiple dialogs by accident if they press enter one too many times. This is problematic because it also means that the consumer is blocked from opening dialogs for certain 300ms intervals. These changes approach the issue differently by moving focus onto the dialog container immediately while it's animating.

Fixes #6560.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Focus still on "open dialog" button after clicked
4 participants