Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tab-nav-bar): check if the subscription is defined #5667

Merged
merged 1 commit into from Jul 13, 2017
Merged

fix(tab-nav-bar): check if the subscription is defined #5667

merged 1 commit into from Jul 13, 2017

Conversation

rafaelss95
Copy link
Contributor

@rafaelss95 rafaelss95 commented Jul 11, 2017 •
edited

Fixes the issue #215 from material.angular.io.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 11, 2017
jelbourn
jelbourn approved these changes Jul 11, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 11, 2017
@jelbourn jelbourn merged commit 0eedb5f into angular:master Jul 13, 2017
@rafaelss95 rafaelss95 deleted the undefined-error branch July 13, 2017 18:45
@rafaelss95 rafaelss95 mentioned this pull request Jul 14, 2017
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rafaelss95 @jelbourn @googlebot