Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(docs): routing breaks on invalid url string #5229

Closed
CaerusKaru opened this issue Jun 20, 2017 · 7 comments
Closed

bug(docs): routing breaks on invalid url string #5229

CaerusKaru opened this issue Jun 20, 2017 · 7 comments
Assignees
Labels
P2 The issue is important to a large percentage of users, with a workaround

Comments

@CaerusKaru
Copy link
Member

CaerusKaru commented Jun 20, 2017

Bug, feature request, or proposal:

Bug

What is the expected behavior?

After navigating to incorrect route, should be able to navigate using the sidenav menu to a valid route

What is the current behavior?

After navigating to incorrect route, cannot navigate to any other route using the sidenav. Effectively stuck in a redirect.

What are the steps to reproduce?

  1. Navigate to material.angular.io
  2. Click on components
  3. Navigate to a component using the sidenav
  4. Edit the URL to change the name of a component to a clearly invalid component name
  5. Try to navigate to any other part of the page using the sidenav or top navigation (the GitHub link still works, probably bc it's an absolute href)

What is the use-case or motivation for changing an existing behavior?

If someone lands on the docs page from an invalid URL, or tries to manually navigate themselves, the whole site breaks.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular Material 2.0.0-beta.7

Stack trace

ERROR TypeError: Cannot read property 'name' of undefined
ERROR Error: Uncaught (in promise): Error: Cannot activate an already activated outlet

@jelbourn jelbourn self-assigned this Jun 20, 2017
@jelbourn jelbourn added the P2 The issue is important to a large percentage of users, with a workaround label Jun 20, 2017
@jelbourn
Copy link
Member

Good catch, thanks

@rafaelss95
Copy link
Contributor

@jelbourn this issue can be closed since it's already fixed by the following PR's angular/material.angular.io#191 and angular/material.angular.io#218

@CaerusKaru
Copy link
Member Author

I don't know if this has been deployed to live yet, but in both the staging website and the live site, the issue persists with a different cause.

On improper route load:
Uncaught (in promise): TypeError: Cannot read property 'unsubscribe' of undefined

Then on attempting to activate another route from sidenav:
Error: Uncaught (in promise): Error: Outlet is not activated

@CaerusKaru CaerusKaru reopened this Jul 14, 2017
@rafaelss95
Copy link
Contributor

It's another error fixed by #5667

@CaerusKaru
Copy link
Member Author

Not if that merge is also live either in staging or production. cc @jelbourn

@jelbourn
Copy link
Member

Haven't done a push yet. Closing issue for now since the fix is merged, will be applied w/ the next hosting push.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Development

No branches or pull requests

3 participants