-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(docs): routing breaks on invalid url string #5229
Comments
Good catch, thanks |
@jelbourn this issue can be closed since it's already fixed by the following PR's angular/material.angular.io#191 and angular/material.angular.io#218 |
I don't know if this has been deployed to live yet, but in both the staging website and the live site, the issue persists with a different cause. On improper route load: Then on attempting to activate another route from sidenav: |
It's another error fixed by #5667 |
Not if that merge is also live either in staging or production. cc @jelbourn |
Haven't done a push yet. Closing issue for now since the fix is merged, will be applied w/ the next hosting push. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal:
Bug
What is the expected behavior?
After navigating to incorrect route, should be able to navigate using the sidenav menu to a valid route
What is the current behavior?
After navigating to incorrect route, cannot navigate to any other route using the sidenav. Effectively stuck in a redirect.
What are the steps to reproduce?
href
)What is the use-case or motivation for changing an existing behavior?
If someone lands on the docs page from an invalid URL, or tries to manually navigate themselves, the whole site breaks.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular Material 2.0.0-beta.7
Stack trace
ERROR TypeError: Cannot read property 'name' of undefined
ERROR Error: Uncaught (in promise): Error: Cannot activate an already activated outlet
The text was updated successfully, but these errors were encountered: