fix(menu): align appearance with spec #5361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kara
reviewed
Jun 26, 2017
src/lib/menu/menu-directive.ts
Outdated
| } | ||
|
|
||
| /** | ||
| * Resets the panel animation ot its initial state. |
src/lib/menu/menu-directive.ts
Outdated
| @@ -156,4 +160,27 @@ export class MdMenu implements AfterContentInit, MdMenuPanel, OnDestroy { | |||
| this._classList['mat-menu-below'] = posY === 'below'; | |||
| } | |||
|
|
|||
| /** | |||
| * Starts the enter animation. | |||
There was a problem hiding this comment.
Formatting nit: Convert these short comments to one line? Same for the others.
/** Starts the enter animation */
|
|
||
| .mat-menu-panel { | ||
| @include mat-menu-base(); | ||
| @include mat-menu-base(2); |
There was a problem hiding this comment.
Can you add a comment clarifying where this elevation number comes from? I couldn't find any guidance in the spec.
There was a problem hiding this comment.
It's nowhere in the spec, this one looked closest to the designs.
crisbeto
force-pushed
the
3814/menu-animation
branch
from
2ca658d
to
d991d7b
Compare
Aligns the menu panel appearance with [the spec](https://material.io/guidelines/components/menus.html) by: * Reducing the elevation from 8 to 3. * Adding a slight border radius. * Tweaking the animation to match the examples. Relates to angular#3814.
crisbeto
force-pushed
the
3814/menu-animation
branch
from
d991d7b
to
4757d2d
Compare
mmalerba
added
the
merge: caretaker note
|
caretaker note: screenshot diffs need approval |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns the menu panel appearance with the spec by:
Relates to #3814.