style(menu): apply theme bg color to menu panel rather than content #3941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the menu's background opacity did not start animating until the menu had scaled to it's full size, despite the menu's drop shadow existing through the animation. Now, the menu's background opacity transitions in sync with the scaling.
googlebot
added
the
cla: yes
|
I now see that this was an explicit change made while adding animations, and that there is a similar convo about this breaking the spec with MdSelect. Is there context that I'm missing? I've read over the design document and watched the official animations for menus and select and don't see where setting the panel background vs the content background is against spec. |
|
@kara I'm interested in hearing your feedback on this |
|
Closing due to change being made in #5361 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the menu's background opacity did not start animating until the menu had scaled to it's full size, despite the menu's drop shadow existing through the animation.
Now, the menu's background opacity transitions in sync with the scaling. The content transitions in after scaling is nearly complete.
[animations are slowed down 10x]
cc @kara