Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): theming mixin error #5254

Merged
merged 1 commit into from Jun 22, 2017

Conversation

crisbeto
Copy link
Member

  • Fixes an error in the input theming mixin that was caused by a nested mixin.
  • Removes the mat-input- prefix from the mixin local variables since they're not exposed and don't need to be prefixed.

Fixes #5232.

* Fixes an error in the input theming mixin that was caused by a nested mixin.
* Removes the `mat-input-` prefix from the mixin local variables since they're not exposed and don't need to be prefixed.

Fixes angular#5232.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 20, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jun 21, 2017
@xonuzofa
Copy link

Your fix allows me to build but is causing an issue with the prefix like so:

<div class="col-sm-6">
    <md-input-container>
        <input mdInput type="text" placeholder="Final Price" formControlName="cost_string">
            <span md-prefix *ngIf="form.controls.cost_string.value">$&nbsp;</span>
    </md-input-container>
</div>

screen shot 2017-06-21 at 9 52 39 pm

@crisbeto
Copy link
Member Author

@xonuzofa These changes only rename some variables and move the mixin out of the other mixin, there is no way for them the affect the prefix. I've checked it against our demo app and it works as expected. That being said, I think your issue comes from the fact that you're using md-prefix, instead of mdPrefix. If you change your span to this, it should work:

<span mdPrefix *ngIf="form.controls.cost_string.value">$&nbsp;</span>

@xonuzofa
Copy link

You are absolutely correct. Thanks!

@aarmora
Copy link

aarmora commented Jun 22, 2017

Is there any planned time for this to be merged? Or is there a workaround in the meantime?

@jelbourn jelbourn merged commit 37efb54 into angular:master Jun 22, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create theme. "Mixins may not be defined within control directives or other mixins."
6 participants