-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(input): theming mixin error #5254
Conversation
* Fixes an error in the input theming mixin that was caused by a nested mixin. * Removes the `mat-input-` prefix from the mixin local variables since they're not exposed and don't need to be prefixed. Fixes angular#5232.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Your fix allows me to build but is causing an issue with the prefix like so:
|
@xonuzofa These changes only rename some variables and move the mixin out of the other mixin, there is no way for them the affect the prefix. I've checked it against our demo app and it works as expected. That being said, I think your issue comes from the fact that you're using
|
You are absolutely correct. Thanks! |
Is there any planned time for this to be merged? Or is there a workaround in the meantime? |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
mat-input-
prefix from the mixin local variables since they're not exposed and don't need to be prefixed.Fixes #5232.