Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(portal): support context in TemplatePortal #6408

Merged
merged 4 commits into from
Aug 21, 2017
Merged

feat(portal): support context in TemplatePortal #6408

merged 4 commits into from
Aug 21, 2017

Commits on Aug 13, 2017

  1. feat(portal): support context in TemplatePortal 

    refactor(portal): align TemplatePortal with ComponentPortal

BREAKING CHANGE:
`TemplatePortal` now requires a generic type (C), method `attach` return type C and property `locals` was removed
method `attachTemplatePortal` in `BasePortalHost` now requires a generic type (C) and returns EmbeddedViewRef<C> (also applies to extending types `DomPortalHost`, `PortalHostDirective` and `MdDialogContainer`)
    @shlomiassaf
    shlomiassaf committed Aug 13, 2017
    Configuration menu
    Copy the full SHA
    2334c3d View commit details
    Browse the repository at this point in the history

  2. feat(dialog): pass user defined data and MdDialogRef instance to te… 

    …mplate context
    @shlomiassaf
    shlomiassaf committed Aug 13, 2017
    Configuration menu
    Copy the full SHA
    aa633c4 View commit details
    Browse the repository at this point in the history

  3. chore: fix linting, tests and peer review adjustments

    @shlomiassaf
    shlomiassaf committed Aug 13, 2017
    Configuration menu
    Copy the full SHA
    7c1bb88 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2017

  1. chore: updates following peer review comments

    @shlomiassaf
    shlomiassaf committed Aug 15, 2017
    Configuration menu
    Copy the full SHA
    d92f913 View commit details
    Browse the repository at this point in the history