Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chips): cursor on remove button and box-shadow transition #6019

Merged
merged 1 commit into from
Jul 28, 2017
+3 −1
Merged

fix(chips): cursor on remove button and box-shadow transition #6019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/lib/chips/chips.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@ $mat-chips-chip-margin: 8px;
}

.mat-chip:not(.mat-basic-chip) {
@include mat-elevation-transition;
display: inline-flex;
padding: $mat-chip-vertical-padding $mat-chip-horizontal-padding $mat-chip-vertical-padding $mat-chip-horizontal-padding;
padding: $mat-chip-vertical-padding $mat-chip-horizontal-padding;
border-radius: $mat-chip-horizontal-padding * 2;
align-items: center;
cursor: default;
Expand Down Expand Up @@ -82,6 +83,7 @@ $mat-chips-chip-margin: 8px;
.mat-chip-remove {
margin-right: $mat-chip-remove-margin-after;
margin-left: $mat-chip-remove-margin-before;
cursor: pointer;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had previously removed it because of this animation https://material.io/guidelines/components/chips.html#chips-behavior, but I certainly understand how pointer helps show purpose

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that example is mostly to show the color change, rather than the cursor.


[dir='rtl'] & {
margin-right: $mat-chip-remove-margin-before;
Expand Down