Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compat): add camelCase selectors to tab label wrapper #5955

Merged
merged 3 commits into from
Jul 27, 2017
Merged

fix(compat): add camelCase selectors to tab label wrapper #5955

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8bedb6
fix(compat): add camelCase selectors to tab label wrapper
andrewseguin Jul 21, 2017
592c8bc
remove internally used dash-case
andrewseguin Jul 25, 2017
570f0cb
remove uses of dash-case
andrewseguin Jul 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/lib/tabs/tab-label-wrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ export const _MdTabLabelWrapperMixinBase = mixinDisabled(MdTabLabelWrapperBase);
* @docs-private
*/
@Directive({
selector: '[md-tab-label-wrapper], [mat-tab-label-wrapper]',
selector: '[md-tab-label-wrapper], [mat-tab-label-wrapper], ' +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this directive purely internal? If so, we should be able to just remove the dash-case selectors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true - removed the dash

'[mdTabLabelWrapper], [matTabLabelWrapper]',
inputs: ['disabled'],
host: {
'[class.mat-tab-disabled]': 'disabled'
Expand Down