Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dialog): set aria-labelledby based on the md-dialog-title #5178

Merged
merged 1 commit into from
Jun 20, 2017

Commits on Jun 17, 2017

  1. fix(dialog): set aria-labelledby based on the md-dialog-title

    * [Based on the accessibility guidelines](https://www.w3.org/TR/wai-aria-practices-1.1/#dialog_modal), these changes add the `aria-labelledby` to dialog that use `md-dialog-title`, which causes the screen reader to read out the title. E.g. before NVDA would read out "Dialog", but now it reads out "Neptune dialog".
    * Adds the MdDialogContainer instance to the dialog injector.
    * Slight refactor of the dialog injector to make a little easier to add more tokens.
    crisbeto committed Jun 17, 2017
    Configuration menu
    Copy the full SHA
    b3e0ea0 View commit details
    Browse the repository at this point in the history