Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): consistent error behavior to md-input-container #4754

Merged
merged 1 commit into from
Jul 27, 2017
Merged

fix(select): consistent error behavior to md-input-container #4754

merged 1 commit into from
Jul 27, 2017

Commits on Jul 26, 2017

  1. fix(select): consistent error behavior to md-input-container 

    * Gets `md-select` to behave in the same way as `md-input-container` when it comes to errors. This means highlighting itself when it is invalid and touched, or one of the parent forms/form groups is submitted.
* Moves the error state logic into a separate function in order to avoid some hard-to-follow selectors and to potentially allow overrides. This should also be a first step to supporting `md-error` inside `md-select`.
* Changes the required asterisk to always have the theme warn color, similarly to the input asterisk.

Fixes angular#4611.
    @crisbeto
    crisbeto committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    57f5f7c View commit details
    Browse the repository at this point in the history