Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@schematics/angular): add twitter link icon #15385

Merged
merged 2 commits into from Aug 21, 2019

Conversation

sjtrimble
Copy link
Contributor

Added twitter link icon to the toolbar of the ng new default project template

Closes #15316

FYI @mgechev | CC: @vikerman

@mgechev mgechev changed the title add twitter link icon fix(@schematics/angular): add twitter link icon Aug 20, 2019
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Aug 21, 2019
@kyliau kyliau merged commit a05148e into angular:master Aug 21, 2019
kyliau pushed a commit that referenced this pull request Aug 21, 2019
* fix(@schematics/angular): add twitter link icon

* fix(@schematics/angular): remove height unit
This was referenced Aug 26, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add link to twitter in the ng new app
5 participants