Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@schematics/angular): addProviderToModule bug: add providers into inner Object #13081

Merged
merged 1 commit into from Nov 30, 2018

Conversation

bsdfzzzy
Copy link
Contributor

@bsdfzzzy bsdfzzzy commented Nov 29, 2018

Fix bug when add providers into module.

Fixes: #13080

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@ngbot
Copy link

ngbot bot commented Nov 29, 2018

Artifact Baseline Current Change
cli/new-production/test-project/main.js 173.60KB 174.00KB +409 bytes

@bsdfzzzy bsdfzzzy changed the title fix @schematics/angular addProviderToModule bug: add providers into inner Object fix(@schematics/angular): addProviderToModule bug: add providers into inner Object Nov 29, 2018
@angular angular deleted a comment from ngbot bot Nov 29, 2018
@ngbot
Copy link

ngbot bot commented Nov 29, 2018

Artifact Baseline Current Change
cli/new-production/test-project/main.js 173.60KB 174.00KB +409 bytes

@ngbot
Copy link

ngbot bot commented Nov 29, 2018

Artifact Baseline Current Change
cli/new-production/test-project/main.js 173.60KB 174.00KB +409 bytes

@bsdfzzzy bsdfzzzy force-pushed the master branch 3 times, most recently from 150a771 to 8bd8769 Compare November 29, 2018 05:56
@googlebot
Copy link

CLAs look good, thanks!

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

Kindly squash your commits into a single one, and also can you kindly add a Unit Test for this?

@bsdfzzzy bsdfzzzy force-pushed the master branch 2 times, most recently from 8e888a4 to d40a4c0 Compare November 29, 2018 13:56
@bsdfzzzy
Copy link
Contributor Author

@alan-agius4 Thanks for checking! I adopted your suggestions and updated this pr.

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Nov 30, 2018
@alan-agius4
Copy link
Collaborator

@bsdfzzzy can you please fix the commit msg as you have a typo?

Thanks

@bsdfzzzy
Copy link
Contributor Author

@alan-agius4 emmm...Which one please...

@alan-agius4
Copy link
Collaborator

with ut should be with it

@bsdfzzzy
Copy link
Contributor Author

@alan-agius4 emmm... I mean Unit Test.

@bsdfzzzy
Copy link
Contributor Author

@alan-agius4 By the way, could you tell me when can this issue be solved if you know?

@vikerman vikerman merged commit 822d6a0 into angular:master Nov 30, 2018
vikerman pushed a commit that referenced this pull request Nov 30, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@schematics/angular error: addProviderToModule error when using interceptor
4 participants