Hybrid/ngUpdate build does not output a changed chunk when updating AngularJS javascript sources #13076
Labels
area: devkit/build-webpack
freq1: low
Only reported by a handful of users who observe it rarely
severity3: broken
type: bug/fix
Milestone
Comments
|
This might be somewhat also related to #12964 This can be simply reproducible, but adding |
alan-agius4
added
freq1: low
vikerman
pushed a commit
that referenced
this issue
Nov 30, 2018
…s` or `resolveJsonModule` (#13089) * fix(@ngtools/webpack): files are not being updated when using `allowJs` or `resolveJsonModule` Fixes #13076 and Fixes #12964 * test: add tests for allowJs and resolveJsonModule in watch mode * test: improve tests for `allowJs` When not using `allowJs` js files are not processed by the tsc compiler, but still processed by webpack. So a correct test should be to check that the JS is transpiled down to ES5 syntax.
vikerman
pushed a commit
that referenced
this issue
Nov 30, 2018
…s` or `resolveJsonModule` (#13089) * fix(@ngtools/webpack): files are not being updated when using `allowJs` or `resolveJsonModule` Fixes #13076 and Fixes #12964 * test: add tests for allowJs and resolveJsonModule in watch mode * test: improve tests for `allowJs` When not using `allowJs` js files are not processed by the tsc compiler, but still processed by webpack. So a correct test should be to check that the JS is transpiled down to ES5 syntax.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ikjelle
pushed a commit
to ikjelle/angular-cli
that referenced
this issue
Mar 26, 2024
…s` or `resolveJsonModule` (angular#13089) * fix(@ngtools/webpack): files are not being updated when using `allowJs` or `resolveJsonModule` Fixes angular#13076 and Fixes angular#12964 * test: add tests for allowJs and resolveJsonModule in watch mode * test: improve tests for `allowJs` When not using `allowJs` js files are not processed by the tsc compiler, but still processed by webpack. So a correct test should be to check that the JS is transpiled down to ES5 syntax.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Bug Report or Feature Request (mark with an
x)Command (mark with an
x)Versions
Windows 7, Node 10 LTS, Angular 7.1.0
Failure Description
I've an Angular project, which is currently upgraded using NgUpgrade from an older AngularJS project. Yesterday, I've updated from Angular 6 to Angular 7 using
ng updateand started the project as usual withng serve.However, I've noticed a strange behaviour with the update. When I've used Angular 6 and I changed some code within the JS-Files from the AngularJS project, the CLI recompiled the app and outputted one changed chunk.
With Angular (CLI) 7, the CLI recompiles after a change as well, but does not output a changed chunk, so the changed code is not there after the live reload. Source Maps are also broken at this point. However, if I change code within a template file of the AngularJS app, then a new chunk will be generated.
In both versions it worked perfectly when changing TypeScript sources (but still, won't update the JS sources within the changed chunk)
Desired functionality
It should work like it did before, so whenever I change code within the AngularJS code base, the recompilation should output a changed chunk with the new code.
I've also noticed, that if I remove
allowJsfrom mytsconfig.app.json, it works as expected with Angular 7.Package Versions:
Angular (CLI/ Compiler CLI, Language Service etc.): 7.1.0
@angular-devkit/build-angular: 0.11.0
The text was updated successfully, but these errors were encountered: