Update: globals configuration support readonly/writable/off (fixes es…

…lint#9940)
aladdin-add · Aug 17, 2018 · 01ae288 · 01ae288
1 parent 985567d
commit 01ae288
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/lib/linter.js b/lib/linter.js
@@ -182,18 +182,21 @@ function parseListConfig(string) {
 function addDeclaredGlobals(globalScope, configGlobals, commentDirectives) {
     Object.keys(configGlobals).forEach(name => {
         let variable = globalScope.set.get(name);
+        const value = configGlobals[name];
 
         if (!variable) {
             variable = new eslintScope.Variable(name, globalScope);
             variable.eslintExplicitGlobal = false;
             globalScope.variables.push(variable);
             globalScope.set.set(name, variable);
         }
-        variable.writeable = configGlobals[name];
+        variable.writeable = value === "writable" || value === true;
+        variable.turnoff = value === "off";
     });
 
     Object.keys(commentDirectives.enabledGlobals).forEach(name => {
         let variable = globalScope.set.get(name);
+        const value = commentDirectives.enabledGlobals[name].value;
 
         if (!variable) {
             variable = new eslintScope.Variable(name, globalScope);
@@ -202,7 +205,8 @@ function addDeclaredGlobals(globalScope, configGlobals, commentDirectives) {
             globalScope.variables.push(variable);
             globalScope.set.set(name, variable);
         }
-        variable.writeable = commentDirectives.enabledGlobals[name].value;
+        variable.writeable = value === "writable" || value === true;
+        variable.turnoff = value === "off";
     });
 
     // mark all exported variables as such