Skip to content

Commit

Permalink
Remove test with complicated conditions
Browse files Browse the repository at this point in the history
  • Loading branch information
ai committed Feb 23, 2018
1 parent 3e4ecd0 commit 6d8b98f
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 30 deletions.
1 change: 0 additions & 1 deletion package.json
Expand Up @@ -34,7 +34,6 @@
"yargs": "^11.0.0"
},
"devDependencies": {
"attr-accept": "^1.1.2",
"cross-spawn": "^6.0.4",
"eslint": "^4.18.1",
"eslint-ci": "^0.1.1",
Expand Down
8 changes: 0 additions & 8 deletions test/cli.test.js
Expand Up @@ -251,14 +251,6 @@ it('uses different units', () => {
})
})

it('shows bytes if value is same in different units', () => {

This comment has been minimized.

Copy link
@TrySound

TrySound Mar 5, 2018

Contributor

Why this test was removed? It covers part of renderer.

This comment has been minimized.

Copy link
@ai

ai Mar 5, 2018

Author Owner

It works unstable. If you find a better way to reproduce it, I am open for PR.

This comment has been minimized.

Copy link
@ai

ai Mar 5, 2018

Author Owner

Maybe we need a way to reproduce it without dependency.

return run([], { cwd: fixture('exact') }).then(result => {
expect(result.out).toContain('Package size: 2287 B')
expect(result.out).toContain('Size limit: 2283 B')
expect(result.code).toEqual(3)
})
})

it('supports absolute path', () => {
const file = path.join(__dirname, 'fixtures/unlimit/empty.js')
return run([file]).then(result => {
Expand Down
3 changes: 0 additions & 3 deletions test/fixtures/exact/index.js

This file was deleted.

12 changes: 0 additions & 12 deletions test/fixtures/exact/package.json

This file was deleted.

6 changes: 0 additions & 6 deletions yarn.lock
Expand Up @@ -288,12 +288,6 @@ atob@^2.0.0:
version "2.0.3"
resolved "https://registry.yarnpkg.com/atob/-/atob-2.0.3.tgz#19c7a760473774468f20b2d2d03372ad7d4cbf5d"

attr-accept@^1.1.2:
version "1.1.2"
resolved "https://registry.yarnpkg.com/attr-accept/-/attr-accept-1.1.2.tgz#6836bfe054e4ef1ee3076fdde56cec9bb3ffead6"
dependencies:
core-js "^2.5.0"

autoprefixer@^6.3.1:
version "6.7.7"
resolved "https://registry.yarnpkg.com/autoprefixer/-/autoprefixer-6.7.7.tgz#1dbd1c835658e35ce3f9984099db00585c782014"
Expand Down

0 comments on commit 6d8b98f

Please sign in to comment.