escape: validation refinements

CHANGELOG.md

@@ -5,6 +5,7 @@
 
 Enhancements:
 
+* escape: validation refinements
 * skip_empty_lines: validation refinements
 * skip_lines_with_empty_values: validation refinements
 * skip_lines_with_error: validation refinements

lib/es5/index.js

@@ -50,7 +50,6 @@ var _require = require('stream'),
 var ResizeableBuffer = require('./ResizeableBuffer');
 
 var default_options = {
-  escape: Buffer.from('"'),
   from: 1,
   from_line: 1,
   objname: undefined,
@@ -164,7 +163,9 @@ function (_Transform) {
     } // Normalize option `escape`
 
 
-    if (typeof options.escape === 'string') {
+    if (options.escape === undefined || options.escape === null) {
+      options.escape = Buffer.from('"');
+    } else if (typeof options.escape === 'string') {
       options.escape = Buffer.from(options.escape);
     }
 

lib/index.js

@@ -10,7 +10,6 @@ const { Transform } = require('stream')
 const ResizeableBuffer = require('./ResizeableBuffer')
 
 const default_options = {
-  escape: Buffer.from('"'),
   from: 1,
   from_line: 1,
   objname: undefined,
@@ -102,7 +101,9 @@ class Parser extends Transform {
       throw new Error(`Invalid Option: delimiter must be a string or a buffer, got ${options.delimiter}`)
     }
     // Normalize option `escape`
-    if(typeof options.escape === 'string'){
+    if(options.escape === undefined || options.escape === null){
+      options.escape = Buffer.from('"')
+    }else if(typeof options.escape === 'string'){
       options.escape = Buffer.from(options.escape)
     }
     if(!Buffer.isBuffer(options.escape)){

test/option.escape.coffee

@@ -3,6 +3,18 @@ parse = require '../lib'
 
 describe 'Option `escape`', ->
 
+  it 'validation', ->
+    parse '', escape: '\\', (->)
+    parse '', escape: Buffer.from('\\'), (->)
+    parse '', escape: null, (->)
+    parse '', escape: undefined, (->)
+    (->
+      parse '', escape: false, (->)
+    ).should.throw 'Invalid Option: escape must be a buffer or a string, got false'
+    (->
+      parse '', escape: true, (->)
+    ).should.throw 'Invalid Option: escape must be a buffer or a string, got true'
+
   describe 'same as quote', ->
 
     it 'is same as quote', (next) ->