callback: pass undefined instead of null

CHANGELOG.md

@@ -5,7 +5,8 @@
 
 This is a complete rewrite based with a Buffer implementation. There are no major breaking changes but it introduces multiple minor breaking changes:
 
-* options `rowDelimiter` is now `record_delimiter`
+* option `rowDelimiter` is now `record_delimiter`
+* option `max_limit_on_data_read` is now `max_record_size`
 * drop the record event
 * normalise error message as `{error type}: {error description}`
 * state values are now isolated into the `info` object
@@ -17,20 +18,20 @@ This is a complete rewrite based with a Buffer implementation. There are no majo
 * drop support for deprecated options `auto_parse` and `auto_parse_date`
 * drop emission of the `record` event
 * in `raw` option, the `row` property is renamed `record`
-* option `max_limit_on_data_read` is now `max_record_size`
 * default value of `max_record_size` is now `0` (unlimited)
 * remove the `record` event, use the `readable` event and `this.read()` instead
 
 New features:
 
-* new options info, from_line and to_line
+* new options `info`, `from_line` and `to_line`
 * trim: respect `ltrim` and `rtrim` when defined
 * delimiter: may be a Buffer
 * delimiter: handle multiple bytes/characters
 * callback: export info object as third argument
 * cast: catch error in user functions
 * ts: mark info as readonly with required properties
 * comment_lines: count the number of commented lines with no records
+* callback: pass undefined instead of null
 
 API management
 

lib/es5/index.js

@@ -331,7 +331,6 @@ function (_Transform) {
 
         if (this.state.wasRowDelimiter === true) {
           this.info.lines++;
-          console.log(this.info.records, this.state.info.records);
 
           if (info === true && this.state.record.length === 0 && this.state.field.length === 0 && this.state.wasQuoting === false) {
             this.state.info = Object.assign({}, this.info);
@@ -946,10 +945,10 @@ var parse = function parse() {
       }
     });
     parser.on('error', function (err) {
-      callback(err, null, parser.info);
+      callback(err, undefined, parser.info);
     });
     parser.on('end', function () {
-      callback(null, records, parser.info);
+      callback(undefined, records, parser.info);
     });
   }
 

lib/index.d.ts

@@ -11,17 +11,18 @@ declare function parse(input: string, callback?: parse.Callback): parse.Parser;
 declare function parse(options?: parse.Options, callback?: parse.Callback): parse.Parser;
 declare function parse(callback?: parse.Callback): parse.Parser;
 declare namespace parse {
-    type Callback = (err: any | Error, output: any, info: Info) => void;
+
+    type Callback = (err: Error | undefined, records: any | undefined, info?: Info) => void;
 
     type MatcherFunc = (value: any) => boolean;
 
     interface Parser extends stream.Transform {}
 
     class Parser {
         constructor(options: Options);
-
+        
         __push(line: any): any;
-
+        
         __write(chars: any, end: any, callback: any): any;
 
         readonly options: Options;

lib/index.js

@@ -695,10 +695,10 @@ const parse = function(){
       }
     })
     parser.on('error', function(err){
-      callback(err, null, parser.info)
+      callback(err, undefined, parser.info)
     })
     parser.on('end', function(){
-      callback(null, records, parser.info)
+      callback(undefined, records, parser.info)
     })
   }
   if(data !== undefined){

test/api.types.ts

@@ -31,6 +31,16 @@ describe('API Types', () => {
       ])
     })
 
+    it('Receive Callback', (next) => {
+      parse('a\nb', function(err: Error, data: object, info: Info){
+        if(err !== undefined){
+          data.should.eql([['a'], ['b']])
+          info.records.should.eql(2)
+        }
+        next(err)
+      })
+    })
+
   })
 
   describe('Info', () => {