rtrim: accept tab

CHANGELOG.md

@@ -1,6 +1,12 @@
 
 # Changelog
 
+## Trunk
+
+Fix:
+
+* rtrim: accept tab
+
 ## Version 4.1.0
 
 New features:

lib/es5/index.js

@@ -69,6 +69,7 @@ var default_options = {
 var cr = 13;
 var nl = 10;
 var space = 32;
+var tab = 9;
 
 var Parser =
 /*#__PURE__*/
@@ -262,7 +263,8 @@ function (_Transform) {
       wasRowDelimiter: false
     };
     return _this;
-  }
+  } // Implementation of `Transform._transform`
+
 
   _createClass(Parser, [{
     key: "_transform",
@@ -278,7 +280,8 @@ function (_Transform) {
       }
 
       callback(err);
-    }
+    } // Implementation of `Transform._flush`
+
   }, {
     key: "_flush",
     value: function _flush(callback) {
@@ -289,7 +292,8 @@ function (_Transform) {
       var err = this.__parse(undefined, true);
 
       callback(err);
-    }
+    } // Central parser implementation
+
   }, {
     key: "__parse",
     value: function __parse(nextBuf, end) {
@@ -561,11 +565,12 @@ function (_Transform) {
         this.info.lines++;
         this.state.wasRowDelimiter = false;
       }
-    }
+    } // Helper to test if a character is a space or a line delimiter
+
   }, {
     key: "__isCharTrimable",
     value: function __isCharTrimable(chr) {
-      return chr === space || chr === cr || chr === nl;
+      return chr === space || chr === tab || chr === cr || chr === nl;
     }
   }, {
     key: "__onRow",

lib/index.js

@@ -29,6 +29,7 @@ const default_options = {
 const cr = 13
 const nl = 10
 const space = 32
+const tab = 9
 
 class Parser extends Transform {
   constructor(opts = {}){
@@ -188,6 +189,7 @@ class Parser extends Transform {
       wasRowDelimiter: false
     }
   }
+  // Implementation of `Transform._transform`
   _transform(buf, encoding, callback){
     if(this.state.stop === true){
       return
@@ -198,13 +200,15 @@ class Parser extends Transform {
     }
     callback(err)
   }
+  // Implementation of `Transform._flush`
   _flush(callback){
     if(this.state.stop === true){
       return
     }
     const err = this.__parse(undefined, true)
     callback(err)
   }
+  // Central parser implementation
   __parse(nextBuf, end){
     const {comment, escape, from, from_line, info, ltrim, max_record_size, quote, raw, relax, rtrim, skip_empty_lines, to, to_line} = this.options
     let {record_delimiter} = this.options
@@ -411,8 +415,9 @@ class Parser extends Transform {
       this.state.wasRowDelimiter = false
     }
   }
+  // Helper to test if a character is a space or a line delimiter
   __isCharTrimable(chr){
-    return chr === space || chr === cr || chr === nl
+    return chr === space || chr === tab || chr === cr || chr === nl
   }
   __onRow(){
     const {columns, info, from, relax_column_count, raw, skip_lines_with_empty_values} = this.options

test/option.rtrim.coffee

@@ -45,6 +45,17 @@ describe 'Option `rtrim`', ->
     parser.write chr for chr in data
     parser.end()
 
+  it 'with tags around quotes', (next) ->
+    data = '''
+    "a\tb\t"\t\t\t,"c\td\t\t\t"\t
+    "e\tf\t"\t,"g\th\t\t\t"\t\t\t
+    '''
+    parser = parse rtrim: true, (err, data) ->
+      data.should.eql [['a\tb\t', 'c\td\t\t\t'],['e\tf\t', 'g\th\t\t\t']] unless err
+      next err
+    parser.write chr for chr in data
+    parser.end()
+
   it 'with char after whitespaces', (next) ->
     data = '''
     "a b " x  ,"c d   " x