cast: function may return non-string values

CHANGELOG.md

@@ -9,6 +9,7 @@ New features:
 
 Fix:
 
+* cast: function may return non-string values
 * stream: pass stream options without modification
 
 ## Version 4.0.1

lib/es5/index.js

@@ -716,7 +716,8 @@ function (_Transform) {
     value: function __onField() {
       var _this$options3 = this.options,
           cast = _this$options3.cast,
-          rtrim = _this$options3.rtrim;
+          rtrim = _this$options3.rtrim,
+          max_record_size = _this$options3.max_record_size;
       var _this$state3 = this.state,
           enabled = _this$state3.enabled,
           wasQuoting = _this$state3.wasQuoting; // Deal with from_to options
@@ -741,8 +742,11 @@ function (_Transform) {
         field = f;
       }
 
-      this.state.record.push(field);
-      this.state.record_length += field.length;
+      this.state.record.push(field); // Increment record length if record size must not exceed a limit
+
+      if (max_record_size !== 0 && typeof field === 'string') {
+        this.state.record_length += field.length;
+      }
 
       this.__resetField();
     }

lib/index.js

@@ -517,7 +517,7 @@ class Parser extends Transform {
     this.state.record_length = 0
   }
   __onField(){
-    const {cast, rtrim} = this.options
+    const {cast, rtrim, max_record_size} = this.options
     const {enabled, wasQuoting} = this.state
     // Deal with from_to options
     if(this.options.columns !== true && enabled === false){
@@ -533,7 +533,10 @@ class Parser extends Transform {
       field = f
     }
     this.state.record.push(field)
-    this.state.record_length += field.length
+    // Increment record length if record size must not exceed a limit
+    if(max_record_size !== 0 && typeof field === 'string'){
+      this.state.record_length += field.length
+    }
     this.__resetField()
   }
   __resetField(){

test/option.cast.coffee

@@ -79,63 +79,83 @@ describe 'Option `cast`', ->
           [ false, true ]
         ] unless err
         next err
+
+      it 'return undefined', ->
+
+    it 'work with record count', (next) ->
+      parse """
+      1,2,3
+      4,5,6
+      """,
+        max_record_size: 10
+        cast: (value, context) ->
+          switch context.index
+            when 0
+              undefined
+            when 1
+              false
+            when 2
+              null
+      , (err, records) ->
+        records.shift().should.eql [undefined, false, null]
+        next err
 
-    describe 'columns', ->
+  describe 'columns', ->
 
-      it 'header is true on first line when columns is true', (next) ->
-        parse """
-        a,b,c
-        1,2,3
-        4,5,6
-        """,
-          columns: true
-          cast: (value, context) ->
-            if context.header then value else parseInt value
-        , (err, records) ->
-          records.should.eql [
-            {a: 1, b: 2, c: 3}
-            {a: 4, b: 5, c: 6}
-          ] unless err
-          next err
+    it 'header is true on first line when columns is true', (next) ->
+      parse """
+      a,b,c
+      1,2,3
+      4,5,6
+      """,
+        columns: true
+        cast: (value, context) ->
+          if context.header then value else parseInt value
+      , (err, records) ->
+        records.should.eql [
+          {a: 1, b: 2, c: 3}
+          {a: 4, b: 5, c: 6}
+        ] unless err
+        next err
 
-      it 'header is false when columns is an object', (next) ->
-        parse """
-        1,2,3
-        4,5,6
-        """,
-          columns: ['a', 'b', 'c']
-          cast: (value, context) ->
-            context.header.should.be.false()
-            parseInt value
-        , (err, records) ->
-          records.should.eql [
-            {a: 1, b: 2, c: 3}
-            {a: 4, b: 5, c: 6}
-          ] unless err
-          next err
+    it 'header is false when columns is an object', (next) ->
+      parse """
+      1,2,3
+      4,5,6
+      """,
+        columns: ['a', 'b', 'c']
+        cast: (value, context) ->
+          context.header.should.be.false()
+          parseInt value
+      , (err, records) ->
+        records.should.eql [
+          {a: 1, b: 2, c: 3}
+          {a: 4, b: 5, c: 6}
+        ] unless err
+        next err
 
-      it 'dont count header line', (next) ->
-        parse """
-        a,b,c
-        1,2,3
-        4,5,6
-        """,
-          columns: true
-          cast: (value, context) ->
-            value
-        , (err, records) ->
-          next err
+    it 'dont count header line', (next) ->
+      parse """
+      a,b,c
+      1,2,3
+      4,5,6
+      """,
+        columns: true
+        cast: (value, context) ->
+          value
+      , (err, records) ->
+        next err
 
-    describe 'error', ->
-      
-      it 'catch error', (next) ->
-        parse """
-        1,2,3
-        4,5,6
-        """,
-          cast: (value) ->
-            if value is '6' then throw Error 'Catchme'
-            value
-        , (err, records) ->
-          err.message.should.eql 'Catchme'
-          next()
+  describe 'error', ->
+
+    it 'catch error', (next) ->
+      parse """
+      1,2,3
+      4,5,6
+      """,
+        cast: (value) ->
+          if value is '6' then throw Error 'Catchme'
+          value
+      , (err, records) ->
+        err.message.should.eql 'Catchme'
+        next()