Pen 553 social links #144
Merged
Pen 553 social links #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JackHowa
commented
Mar 3, 2020
JackHowa
commented
- jira https://arcpublishing.atlassian.net/secure/RapidBoard.jspa?rapidView=545&projectKey=PEN&modal=detail&selectedIssue=PEN-553&assignee=5e387d6a1b1d910e5dfd7a9b
added 7 commits
March 2, 2020 16:57
beltrancaliz
reviewed
Mar 4, 2020
| @@ -19,6 +19,7 @@ import { | |||
| SoundCloudIcon, | |||
| RssIcon, | |||
| } from '@arc-test-org/engine-theme-sdk'; | |||
| import constructSocialURL from './shared/constructSocialURL'; | |||
There was a problem hiding this comment.
Since there are several blocks that use this function should we came it under utils or similar?
There was a problem hiding this comment.
do we have shared js right now? not sure if there's an example of that. will look
There was a problem hiding this comment.
good plan. I might make an engine issue of refactoring. So that we can do this from there.
beltrancaliz
reviewed
Mar 4, 2020
beltrancaliz
reviewed
Mar 4, 2020
added 2 commits
March 4, 2020 09:23
…-theme-blocks into PEN-553-social-links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.