New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mixin support #990
Mixin support #990
Conversation
…an intersection type. In such case, "inherit" from all parts of such type. Do not mark properties inherited from class expression as static
Awesome! I wonder if this will help with any other reflection mergin issues we have. |
So the build passed on Node 10 but not node 6 because of a tslint error. That seems strange...
Sorry it's so grouchy. 👿 |
I was not changing those files, but added whitespace anyway, hopefully build will pass this time :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! This looks great. Only remaining issue is that I would like to have render tests though so we make sure this doesn't break in the future. The example is helpful but won't alert us if things change.
Co-Authored-By: SamuraiJack <nickolay8@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Work!
@aciccarello Thank you! |
This PR adds support for mixins, as per https://www.bryntum.com/blog/the-mixin-pattern-in-typescript-all-you-need-to-know/
The most important changes:
Type1 & Type2
. In such case, "inherit" from every component of such type