feat(cli): if no out or json cmd, put out to ./docs #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aciccarello
requested changes
Feb 8, 2019
Co-Authored-By: artentica <riouallonvincent@gmail.com>
Co-Authored-By: artentica <riouallonvincent@gmail.com>
|
I accept the modification (directly on github (didn't know it was possible ^^)) |
|
I'm not sure i ask: I cannot merge even if you (@aciccarello) approved no ? |
|
I'm leaving it open in case someone else wanted to chime in. I'll merge before the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I not really happy with this solution but idk how do another way.
If you have an idea i'll be happy to implement it
Closes #746