Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand JS files if allowJS is enabled #948

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Expand JS files if allowJS is enabled #948

merged 1 commit into from
Jan 17, 2019

Conversation

Gerrit0
Copy link
Collaborator

@Gerrit0 Gerrit0 commented Jan 12, 2019

Fixes #911

@aciccarello
Copy link
Collaborator

Makes sense. Does this result in duplicate files if someone has their .ts files compiled in place (in the same directory) while using allowJs?

@Gerrit0
Copy link
Collaborator Author

Gerrit0 commented Jan 12, 2019

I suppose it could result in duplicate files, but, if I understand the allowJs option correctly, this shouldn't be an issue since typescript would complain that input files would be overwritten. With an outDir set, the compiled .ts files should be in a directory that isn't being expanded and thus this wouldn't result in duplicate files.

@aciccarello aciccarello merged commit 6e77522 into master Jan 17, 2019
@aciccarello aciccarello deleted the fix/find-js-files branch January 17, 2019 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gerrit0 @aciccarello