Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for excluding directories and refactor expandInputFiles. #730

Merged
merged 3 commits into from May 10, 2019
Merged

Add support for excluding directories and refactor expandInputFiles. #730

merged 3 commits into from May 10, 2019

Conversation

meowtec
Copy link
Contributor

@meowtec meowtec commented Mar 28, 2018

I am creating this pull request because I have the problem when using TypeDoc.

Command:

typedoc --exclude "**/node_modules/**" --ignoreCompilerErrors --out tsdoc .

Stderr:

ENAMETOOLONG: name too long, stat '/Users/myObject/node_modules/@types/body-parser/node_modules/@types/express/node_modules/@types/body-parser/node_modules/@types/express/node_modules/@types/body-parser/node_modules/@types/express/node_modules/@types/body-parser/node_modules/@types/express/node_modules/@types/body-parser/node_modules/@types/express/node_modules/@types/body-parser/node_modules/@types/express/node_modules/@types/body-parser/node_modules/@types/express/node_modules/@types/body-parser/node_modules/@types/express/node_modules/@types/body-parser/node_modules/@types/express/node_modules/@types/body-parser/node_modules/@types/express/node_modules/@types/body-parser/node_modules/@types/express/node_modules/@types/body-parser/node_modules/@types/express/node_modules/@types/body-parser/node_modules/@types/express/node_modules/@types/body-parser/node_modules/@types/express/node_modules/@types/body-parser/node_modules/@types/express/node_modules/@types/body-parser/node_modules/@types/express/node_modules/@types/body-parser'

It was due to a symbolic link recursion, caused by npminstall, a alternative npm install tool, which I have to use for some reasons.

This pull request make isExcluded checking for both directories and files. We can stop the file walking when the directory is excludes. It is also better for IO performance.

@Gerrit0 Gerrit0 merged commit 682aaf2 into TypeStrong:master May 10, 2019
@Gerrit0
Copy link
Collaborator

Gerrit0 commented May 10, 2019

Thanks for the contribution! Sorry this took so long to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants