New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check for null variable when excludeNotExported is true #694
Conversation
Thanks! I was just working on that but this is great! |
@aciccarello Thank you for the prompt acceptance. I look forward to a new |
Thanks for a prompt PR! I'm going to hold off on a patch release for now in case there are any other issues from the last release. I also want to improve some of the test flakiness so the release process is easier. |
Awesome! Thanks for the quick response guys! 👍 |
Can be re-enabled once TypeStrong/typedoc#694 is released. Probably in 0.10.1
Can be re-enabled once TypeStrong/typedoc#694 is released. Probably in 0.10.1
Awesome work! I was just visiting the repo to find this :) any word on when a 0.10.1 will go out with this fix @aciccarello? |
I can confirm that latest master fixes this issue for me too @aciccarello |
* 'master' of github.com:TypeStrong/typedoc: Don't write BOM for search index file (TypeStrong#705) fix: check for null variable when excludeNotExported is true (TypeStrong#694) 0.10.0 Update dependencies (TypeStrong#689) Allow multiple excludes (TypeStrong#592) fix(package): update fs-extra to version 5.0.0 (TypeStrong#661) fix(package): update @types/highlight.js to version 9.12.0 (TypeStrong#647) Fix `--plugin` argument parsing (TypeStrong#682) update renderer specs Upgrade tslint to 5.9.1 (TypeStrong#683) Implemented '--excludeProtected' option similar to the '--excludePriv… (TypeStrong#666) Use remove component method (TypeStrong#664) Added support for generic type aliases (TypeStrong#622) dont parse comment for tags inside a code block (TypeStrong#633) # Conflicts: # package.json # src/lib/utils/options/sources/component.ts
The PR fixes the TypeError when
excludeNotExported
option is set totrue
against the following TS file:The stack trace was: