Allow TraverseCallback to bail out early #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is used in getChildByName to search children, which led to *always* searching all children, which is especially problematic for any deeply nested structures. Improves convert time by 25% on the monaco.d.ts file in #975
aciccarello
approved these changes
May 8, 2019
| this.children.slice().forEach((child: DeclarationReflection) => { | ||
| callback(child, TraverseProperty.Children); | ||
| }); | ||
| for (const child of toArray(this.children).slice()) { |
There was a problem hiding this comment.
Do you need to slice if you are already doing toArray?
There was a problem hiding this comment.
Good catch, I assumed toArray just returned the input if it was an array, but apparently it copies the array. Will remove.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is used in
getChildByNamewhen searching for a reflection by name, which led to always searching all children, which is especially problematic for any deeply nested structures.Improves convert time by 25% on the monaco.d.ts file in #975