update typescript #1014
update typescript #1014
Conversation
| if (reflection instanceof DeclarationReflection) { | ||
| file.reflections.push(reflection); | ||
| } | ||
|
|
||
| reflection.sources.push({ | ||
| sources.push({ |
There was a problem hiding this comment.
This change is needed, because file.reflections.push(reflection) can potentially mutate sources key. Without this change there is an "object can be possibly undefined" error.
I guess, typescript 3.4 became smarter and requires us to have an explicit stored reference to the array.
|
@aciccarello do you need anything else from me before this PR can be merged? |
|
@just-boris Thanks for identifying the new compilation errors. Hopefully I've found a way to avoid the variable assignment. Honestly is surprised me that typedoc complained about the existing code but then accepted that the array would be defined. Once this passes CI we should be able to merge. |
|
Awesome! Thank you! |
|
Great stuff! @aciccarello could you release typedoc with typescript 3.4 support? |
|
@aciccarello just curious when you plan on releasing again? Would love to use this with TS 3.4! |
|
@styu a release is in progress, there appear to be a couple problems with the default theme which we are trying to address. |
|
Seems like you guys should mark this as a peer dependency so that you don't have to make a pr every time typescript releases a new version, and to prevent blocking people using this. Any updates on when this will get released? |
Bring the latest typescript version in.