Reset the state of the comment plugin on conversion start. #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts most of commit 3716ba7.
These were not affected by the revert in the previous commit.
In the test suite, a single app is reused for all the converter tests. If the plugins do not appropriately reset their state at the start of a conversion, then one test may affect later tests.
|
Thanks for finding this. It would be great to eventually rework the testing model to avoid issues like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the test suite, a single app is reused for all the converter tests. If the plugins do not appropriately reset their state at the start of a conversion, then one test may affect later tests.
CommentPlugindid not reset itshiddenfield. This caused all converter tests after thecommenttest to be messed up. In all subsequent tests, the reflections withid4 and 5 were deleted fromproject.reflections. This prevented plugins that followCommentPluginfrom acting on reflections 4 and 5. They were still part of the reflection tree however, and were still output, just with incomplete or incorrect values. For instance,kindStringwas not populated by theGroupPlugin, andfileNamewas not trimmed by theSourcePlugin.Commit 3716ba7 incorrectly modified all the tests that were failing due to the incorrect code so that they'd conform to the incorrect output. This PR reverses most of that commit.
Closes #828.