Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configFile option #607

Merged
merged 1 commit into from Aug 26, 2017
Merged

Add configFile option #607

merged 1 commit into from Aug 26, 2017

Conversation

loilo
Copy link
Contributor

@loilo loilo commented Aug 25, 2017

This deprecates the configFileName option and renames it to configFile.
It keeps its user-facing behaviour, improving some path resolutions under the hood.
Using the configFileName option will now raise a logWarning in the console.

This deprecates the `configFileName` option and renames it to `configFile`.
It keeps its user-facing behaviour, improving some path resolutions under the hood.
Using the `configFileName` option will now raise a `logWarning` in the console.
@johnnyreilly
Copy link
Member

Thanks! I'll try and take a look this weekend. Tests pass!

@johnnyreilly johnnyreilly merged commit fbd64be into TypeStrong:master Aug 26, 2017
@johnnyreilly
Copy link
Member

Brilliant - thanks!

@johnnyreilly
Copy link
Member

shipped with v2.3.4 - thanks for your help!

@loilo
Copy link
Contributor Author

loilo commented Aug 26, 2017

My pleasure. 🙃

@loilo loilo deleted the config-file-option branch August 26, 2017 14:55
@develar
Copy link
Contributor

develar commented Aug 27, 2017

So cool, electron-webpack uses ts-loader in the user projects and in any case have to find tsconfig (and set to fork-ts-checker-webpack-plugin if need, option tsconfig) So, a little bit more reliable (because don't rely on ts-loader logic anymore — no logic duplication) and faster. Thanks a lot.

@loilo
Copy link
Contributor Author

loilo commented Aug 27, 2017

@develar Glad that it helped.

I'm still wondering if this option could need an additional per-entry-point configurability, something like this:

configFile: {
  '*': 'tsconfig.json', // ← default value
  'named-entry-point-a': '/var/www/tsconfig.json',
  'named-entry-point-b': 'wildly-different-name.json'
}

Before possibly opening an issue about this, what do you @develar as an experienced ts-loader user think about this?

@develar
Copy link
Contributor

develar commented Aug 28, 2017

@loilo I think it is not required. Currently, we use one tsconfig.json for both parts (Electron app consists of two parts — code for renderer process and code for main process). I cannot imagine when it can be required :)

@loilo
Copy link
Contributor Author

loilo commented Aug 28, 2017

Okay, thanks for your feedback – I guess then I could go deeper in thinking about this instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants