Speculative fix for #565 #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johnnyreilly - Thanks, this PR fixes the issue for me! I put together a small repro case that fails with ts 2.4.1 here: https://github.com/stephen/ts-test - applying this change passes the build again. |
|
Great thanks! Planning to release this in about 3 hours time. |
|
@johnnyreilly Great works! This fix really saves my day! |
|
Great! |
frederickfogerty
added a commit
to frederickfogerty/create-react-app-typescript
that referenced
this pull request
Jul 5, 2017
Ts-loader version 2.2.1 is the minimum version required to work on typescript 2.4.1, see TypeStrong/ts-loader#566 for more details.
sven3270350
added a commit
to sven3270350/react-typescript
that referenced
this pull request
Aug 11, 2022
Ts-loader version 2.2.1 is the minimum version required to work on typescript 2.4.1, see TypeStrong/ts-loader#566 for more details.
OrdinalKing
pushed a commit
to OrdinalKing/create-react-app-ts-redux-saga-mui
that referenced
this pull request
Aug 26, 2022
Ts-loader version 2.2.1 is the minimum version required to work on typescript 2.4.1, see TypeStrong/ts-loader#566 for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.