Report errors in JS(X) files when CheckJS is enabled (#564)

TypeStrong · Jun 25, 2017 · bcbb3ce · bcbb3ce
1 parent efe487f
commit bcbb3ce
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/after-compile.ts b/src/after-compile.ts
@@ -124,9 +124,12 @@ function provideErrorsToWebpack(
     modules: Modules,
     instance: interfaces.TSInstance
 ) {
-    const { compiler, languageService, files, loaderOptions } = instance;
+    const { compiler, languageService, files, loaderOptions, compilerOptions } = instance;
+
+    let filePathRegex = !!compilerOptions.checkJs ? constants.dtsTsTsxJsJsxRegex : constants.dtsTsTsxRegex;
+
     Object.keys(filesToCheckForErrors)
-        .filter(filePath => !!filePath.match(constants.dtsTsTsxRegex))
+        .filter(filePath => !!filePath.match(filePathRegex))
         .forEach(filePath => {
             const errors = languageService.getSyntacticDiagnostics(filePath).concat(languageService.getSemanticDiagnostics(filePath));
             if (errors.length > 0) {

diff --git a/src/constants.ts b/src/constants.ts
@@ -15,6 +15,7 @@ export const ModuleKindCommonJs = 1;
 export const tsTsxRegex = /\.ts(x?)$/i;
 export const dtsDtsxRegex = /\.d\.ts(x?)$/i;
 export const dtsTsTsxRegex = /(\.d)?\.ts(x?)$/i;
+export const dtsTsTsxJsJsxRegex = /((\.d)?\.ts(x?)|js(x?))$/i;
 export const tsTsxJsJsxRegex = /\.tsx?$|\.jsx?$/i;
 export const jsJsx = /\.js(x?)$/i;
 export const jsJsxMap = /\.js(x?)\.map$/i;