Fix: ignore MemberExpression in VariableDeclarators (fixes eslint#6795)

Chained properties on objects will typically not be indented as the rule expects in variable declarations. For now, ignore variable declarations (as was done in the previous version of ESLint, where all chained properties were ignored) and possibly revisit later to offer users opportunity to enforce alignment and/or sensible indentation.
Trott · Jul 29, 2016 · 977e24f · 977e24f
1 parent 5230310
commit 977e24f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/lib/rules/indent.js b/lib/rules/indent.js
@@ -813,6 +813,10 @@ module.exports = {
                     return;
                 }
 
+                if (getVariableDeclaratorNode(node)) {
+                    return;
+                }
+
                 let propertyIndent = getNodeIndent(node) + indentSize * options.MemberExpression;
 
                 let checkNodes = [node.property];

diff --git a/tests/lib/rules/indent.js b/tests/lib/rules/indent.js
@@ -1376,6 +1376,12 @@ ruleTester.run("indent", rule, {
             "    .foo\n" +
             "    .bar",
             options: [2, {MemberExpression: 2}]
+        },
+        {
+            code:
+            "var foo = bar.baz()\n" +
+            "             .bip();",
+            options: [2]
         }
     ],
     invalid: [