Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few Closure annotations #5557

Merged
merged 2 commits into from
Jun 15, 2019
Merged

Fix a few Closure annotations #5557

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0810bf3
Fix some Closure annotations
aomarks Jun 14, 2019
a6bff43
Add @return description
aomarks Jun 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/legacy/legacy-element-mixin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,6 +517,8 @@ export const LegacyElementMixin = dedupingMixin((base) => {
* is contained. This is a shorthand for
* `this.getRootNode().host`.
* @this {Element}
* @return {?Node} The element whose local dom within which this element is
* contained.
*/
get domHost() {
let root = wrap(this).getRootNode();
Expand Down Expand Up @@ -940,9 +942,9 @@ export const LegacyElementMixin = dedupingMixin((base) => {
* Cross-platform helper for setting an element's CSS `translate3d`
* property.
*
* @param {number} x X offset.
* @param {number} y Y offset.
* @param {number} z Z offset.
* @param {number|string} x X offset.
* @param {number|string} y Y offset.
* @param {number|string} z Z offset.
* @param {Element=} node Element to apply the transform to.
* Defaults to `this`.
* @return {void}
Expand Down