Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix class$ bindings for ShadyDOM.noPatch mode #5534

Merged
merged 2 commits into from May 6, 2019
Merged

Fix class$ bindings for ShadyDOM.noPatch mode #5534

merged 2 commits into from May 6, 2019

Conversation

dfreedm
Copy link
Member

@dfreedm dfreedm commented May 3, 2019

Reference Issue

@dfreedm dfreedm requested a review from sorvell May 3, 2019 23:28
sorvell
sorvell suggested changes May 3, 2019
View reviewed changes
Copy link
Contributor

@sorvell sorvell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test. This should be something that binds to a class with an undefined value.

@dfreedm
Copy link
Member Author

dfreedm commented May 3, 2019

Let's add a test. This should be something that binds to a class with an undefined value.

Test added

@dfreedm dfreedm merged commit 3b6f334 into master May 6, 2019
@dfreedm dfreedm deleted the removeAttribute-scoping branch May 6, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorvell sorvell sorvell approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

@TimvdLippe TimvdLippe Awaiting requested review from TimvdLippe

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dfreedm @sorvell @googlebot