Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): upgrades lerna to 6.x.x #2828

Closed
wants to merge 428 commits into from

Conversation

pavankjadda
Copy link
Contributor

@pavankjadda pavankjadda commented Jun 23, 2022

PR Checklist

  • Brief description of changes
  • Links to any relevant issues
  • Required status checks are passing
  • User cases if changes impact the user's experience
  • @mention a maintainer to request a review

Updates lerna version to 5.1.4

  1. Lerna is now maintained by NX team at Nrwl
  2. Version 5.1.4 includes bug fixes and performance improvements

igoroctaviano and others added 30 commits February 5, 2021 15:40
 - @ohif/extension-cornerstone@2.10.1
 - @ohif/extension-dicom-html@1.3.1
 - @ohif/extension-dicom-rt@0.6.4
 - @ohif/extension-dicom-segmentation@0.5.2
 - @ohif/extension-dicom-tag-browser@0.2.1
 - @ohif/extension-vtk@1.10.3
 - @ohif/core@2.12.2
 - @ohif/viewer@4.8.8
IDC-2258: Replace instance dropdown to slider for dicom tag browser
 - @ohif/extension-dicom-tag-browser@0.2.2
 - @ohif/extension-vtk@1.10.4
 - @ohif/core@2.12.3
 - @ohif/ui@1.8.2
 - @ohif/viewer@4.8.9
IDC-2251: Add error page and not found pages if failed to retrieve study data
 - @ohif/viewer@4.8.10
* add acknowldgment of IDC

resolves OHIF#1136

* Fix typo + remove IDC ack example

Co-authored-by: igoroctaviano <igoroctaviano@gmail.com>
dcmjs
  * @ohif/core: 0.17.2 → 0.18.1
  * @ohif/extension-cornerstone: 0.17.2 → 0.18.1
  * @ohif/extension-dicom-html: 0.17.2 → 0.18.1
  * @ohif/extension-dicom-rt: 0.17.2 → 0.18.1
  * @ohif/extension-dicom-segmentation: 0.17.2 → 0.18.1
  * @ohif/extension-dicom-tag-browser: 0.17.2 → 0.18.1
  * @ohif/extension-vtk: 0.17.2 → 0.18.1
  * @ohif/viewer: 0.17.2 → 0.18.1
Update dependency: dcmjs@0.18.1
 - @ohif/extension-cornerstone@2.10.2
 - @ohif/extension-dicom-html@1.3.2
 - @ohif/extension-dicom-rt@0.6.5
 - @ohif/extension-dicom-segmentation@0.5.3
 - @ohif/extension-dicom-tag-browser@0.2.3
 - @ohif/extension-vtk@1.10.5
 - @ohif/core@2.12.4
 - @ohif/viewer@4.8.11
dcmjs
  * @ohif/core: 0.18.1 → 0.18.2
  * @ohif/extension-cornerstone: 0.18.1 → 0.18.2
  * @ohif/extension-dicom-html: 0.18.1 → 0.18.2
  * @ohif/extension-dicom-rt: 0.18.1 → 0.18.2
  * @ohif/extension-dicom-segmentation: 0.18.1 → 0.18.2
  * @ohif/extension-dicom-tag-browser: 0.18.1 → 0.18.2
  * @ohif/extension-vtk: 0.18.1 → 0.18.2
  * @ohif/viewer: 0.18.1 → 0.18.2
Update dependency: dcmjs@0.18.2
 - @ohif/extension-cornerstone@2.10.3
 - @ohif/extension-dicom-html@1.3.3
 - @ohif/extension-dicom-rt@0.6.6
 - @ohif/extension-dicom-segmentation@0.5.4
 - @ohif/extension-dicom-tag-browser@0.2.4
 - @ohif/extension-vtk@1.10.6
 - @ohif/core@2.12.5
 - @ohif/viewer@4.8.12
feat(IDC-2223): add new log service to be used by debugger extension
 - @ohif/extension-debugging@0.2.0
 - @ohif/extension-dicom-microscopy@0.52.0
 - @ohif/extension-dicom-segmentation@0.6.0
 - @ohif/extension-vtk@1.11.0
 - @ohif/core@2.13.0
 - @ohif/ui@1.9.0
 - @ohif/viewer@4.9.0
…y rebuilds (OHIF#2274)

* Added memoization on VTKMPRToolbarButton component to avoid unnecessary rebuilds

* update isDisplaySetReconstructable for float precision

Co-authored-by: Rodrigo Cáceres Vicencio <rcaceres@nursoft.cl>
Co-authored-by: Davide Punzo <punzodavide@hotmail.it>
 - @ohif/extension-vtk@1.11.1
 - @ohif/viewer@4.9.1
 - @ohif/extension-cornerstone@2.10.4
 - @ohif/extension-dicom-html@1.3.4
 - @ohif/extension-dicom-rt@0.6.7
 - @ohif/extension-dicom-segmentation@0.6.1
 - @ohif/extension-dicom-tag-browser@0.2.5
 - @ohif/extension-vtk@1.11.2
 - @ohif/core@2.13.1
 - @ohif/viewer@4.9.2
react-cornerstone-viewport
  * @ohif/extension-cornerstone: 4.0.4 → 4.0.5
…e-viewport-4.0.5

Update dependency: react-cornerstone-viewport@4.0.5
GitanjaliChhetri and others added 20 commits October 25, 2022 10:06
…IF#2972)

* fix: 2965 Correct Parsing Logic for Qualitative Instance Level SR

* fix: 2965 Correct Parsing Logic for Qualitative Instance Level SR

* fix: 2965 Correct Parsing Logic for Qualitative Instance Level SR
 - @ohif/extension-vtk@1.12.36
 - @ohif/core@2.16.30
 - @ohif/viewer@4.12.42
 - @ohif/extension-dicom-segmentation@0.7.16
 - @ohif/extension-vtk@1.12.37
 - @ohif/core@2.16.31
 - @ohif/viewer@4.12.43
 - @ohif/extension-vtk@1.12.38
 - @ohif/core@2.16.32
 - @ohif/viewer@4.12.44
 - @ohif/extension-vtk@1.12.39
 - @ohif/core@2.16.33
 - @ohif/viewer@4.12.45
 - @ohif/extension-dicom-segmentation@0.7.17
 - @ohif/extension-vtk@1.12.40
 - @ohif/core@2.16.34
 - @ohif/viewer@4.12.46
…#3073)

* fix: OHIF#2964 Reword message for segmentation error loading due to orientation tolerance

* fix: Show eye-icon when segment name is long

* update python version
 - @ohif/extension-dicom-segmentation@0.7.18
 - @ohif/viewer@4.12.47
 - @ohif/extension-cornerstone@2.12.16
 - @ohif/extension-dicom-html@1.3.24
 - @ohif/extension-dicom-rt@0.7.14
 - @ohif/extension-dicom-segmentation@0.7.19
 - @ohif/extension-dicom-tag-browser@0.2.25
 - @ohif/extension-vtk@1.12.41
 - @ohif/core@2.16.35
 - @ohif/viewer@4.12.48
 - @ohif/extension-dicom-segmentation@0.7.20
 - @ohif/viewer@4.12.49
* chore: update issue templates

* add template to PRs

* update for pr titles

* update

* update

* update description
* fix: OHIF#3077 update seg tolerance popup and update seg thumbnail warning

* jump to first segment item image

* Shows warning message only once on onChange
 - @ohif/extension-dicom-segmentation@0.7.21
 - @ohif/viewer@4.12.50
@pavankjadda pavankjadda changed the title feat(deps): upgrades lerna to 5.x.x feat(deps): upgrades lerna to 6.x.x Mar 3, 2023
@pavankjadda pavankjadda requested a review from sedghi March 3, 2023 17:31
@pavankjadda
Copy link
Contributor Author

@sedghi As I said before, lerna and NX are two different projects maintained by same company. They are making very good improvements to Lerna. I think we can go ahead and use 6.5.x version. They also made upgrade painless.

@sedghi
Copy link
Member

sedghi commented Mar 3, 2023

@pavankjadda Hey
We are pushing the v3-stable branch to master soon, I'm more interested in that upgrade than the v2. Have you tried it on the v3-stable?

@pavankjadda pavankjadda changed the base branch from master to v3-stable March 3, 2023 19:46
@pavankjadda
Copy link
Contributor Author

@pavankjadda Hey We are pushing the v3-stable branch to master soon, I'm more interested in that upgrade than the v2. Have you tried it on the v3-stable?

I can create new PR of v3-stable. Would that be okay?

@sedghi
Copy link
Member

sedghi commented Mar 3, 2023

yes indeed

@pavankjadda
Copy link
Contributor Author

yes indeed

Okay. Created #3215 on v3-stable

@pavankjadda pavankjadda closed this Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet