Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Rule: template-render-format #1

Merged
merged 12 commits into from Aug 31, 2017
Merged

New Rule: template-render-format #1

merged 12 commits into from Aug 31, 2017

Conversation

jleja
Copy link
Contributor

@jleja jleja commented Aug 30, 2017

  • Adds template-render-format as the first MT custom linting rule
  • Ensures proper formatting for rendering components in tests:
    • Single property components
    • Single property components wrapped in body tags
    • Single property component block templates
    • Single property component block templates wrapped in body tags
    • Multiple property components
    • Multiple property components wrapped in body tags
    • Multiple property component block templates
    • Multiple property component block templates wrapped in body tags
  • Adds some common repo files, such as yarn lock, editor config, and Circle CI
  • Adds linting rules based on those from other Mariana projects, removing any plugins/globals that were Ember-project specific

@RobbieTheWagner
Copy link

Looks good! Appreciate the work you put into this 👍 . If you wanted to implement another rule, while you're at it, I've been following this one eslint/eslint#5949

@jleja
Copy link
Contributor Author

jleja commented Aug 31, 2017

@rwwagner90 Maybe not in this PR, but certainly something to look into after sprint commitments are taken care of. :)

@jleja jleja merged commit bfc4d67 into master Aug 31, 2017
@jleja jleja deleted the template-render-format branch August 31, 2017 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants