Skip to content
This repository has been archived by the owner on Mar 17, 2022. It is now read-only.

Commit

Permalink
Fix link to open in cloud shell button image.
Browse files Browse the repository at this point in the history
  • Loading branch information
jmdobry committed Mar 14, 2018
1 parent e441e91 commit 7b3af41
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 6 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
@@ -1,3 +1,8 @@
##### 2.2.3 - 14 March 2018

###### Bug fixes
- Fix link to "Open in Cloud Shell" button image

##### 2.2.2 - 13 March 2018

###### Bug fixes
Expand Down
2 changes: 1 addition & 1 deletion package.json
@@ -1,7 +1,7 @@
{
"name": "@google-cloud/nodejs-repo-tools",
"description": "Tools used to maintain and test Node.js repositories in the GoogleCloudPlaftorm organization.",
"version": "2.2.2",
"version": "2.2.3",
"license": "Apache-2.0",
"author": "Google Inc.",
"engines": {
Expand Down
2 changes: 1 addition & 1 deletion templates/lib_readme.tpl
Expand Up @@ -141,4 +141,4 @@ See [LICENSE](https://github.com{{repoPath}}/blob/master/LICENSE)

[client-docs]: {{client_reference_url}}
[product-docs]: {{docs_url}}
[shell_img]: http://gstatic.com/cloudssh/images/open-btn.png
[shell_img]: //gstatic.com/cloudssh/images/open-btn.png
2 changes: 1 addition & 1 deletion templates/lib_samples_readme.tpl
Expand Up @@ -50,5 +50,5 @@ __Usage:__ `{{{usage.text}}}`
[{{id}}_{{@index}}_code]: {{file}}{{/if}}{{/if}}
{{/each}}

[shell_img]: http://gstatic.com/cloudssh/images/open-btn.png
[shell_img]: //gstatic.com/cloudssh/images/open-btn.png
[shell_link]: https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com{{repoPath}}&page=editor&open_in_editor=samples/README.md
2 changes: 1 addition & 1 deletion templates/python/lib_readme.tpl
Expand Up @@ -111,7 +111,7 @@ samples.
{{#each samples}}
\| {{name}} \| `source code <https://github.com{{../repoPath}}/blob/master/samples/{{file}}>`__ \| |Open in Cloud Shell {{name}}| \|

.. |Open in Cloud Shell {{name}}| image:: http://gstatic.com/cloudssh/images/open-btn.png
.. |Open in Cloud Shell {{name}}| image:: //gstatic.com/cloudssh/images/open-btn.png
:target: https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com{{../repoPath}}&page=editor&open_in_editor=samples/{{file}},samples/README.md

{{/each}}
Expand Down
4 changes: 2 additions & 2 deletions templates/python/lib_samples_readme.tpl
Expand Up @@ -45,7 +45,7 @@ View the `source code <{{file}}>`__.

|Open in Cloud Shell {{name}}|

.. |Open in Cloud Shell {{name}}| image:: http://gstatic.com/cloudssh/images/open-btn.png
.. |Open in Cloud Shell {{name}}| image:: //gstatic.com/cloudssh/images/open-btn.png
:target: https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com{{../repoPath}}&page=editor&open_in_editor=samples/{{file}},samples/README.md


Expand All @@ -66,5 +66,5 @@ View the `source code <{{file}}>`__.
{{/if}}
{{/each}}

.. |Open in Cloud Shell| image:: http://gstatic.com/cloudssh/images/open-btn.png
.. |Open in Cloud Shell| image:: //gstatic.com/cloudssh/images/open-btn.png
:target: https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com{{repoPath}}&page=editor&open_in_editor=samples/README.md

3 comments on commit 7b3af41

@drewrothstein
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmdobry just a heads-up, I don't think the http: removal for the image works. Maybe just change to https?

Working examples:
https://github.com/googleapis/nodejs-logging-bunyan
https://github.com/googleapis/nodejs-logging-winston

Non-working examples:
https://github.com/googleapis/nodejs-bigtable
https://github.com/googleapis/nodejs-translate
https://github.com/googleapis/nodejs-logging
https://github.com/googleapis/nodejs-compute

The working ones have http while the non-working ones have this change.

@jmdobry
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess markdown doesn't have great support for protocol-relative URLs. I'll want to just change it to https

@jmdobry
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, the fix will roll out to the repos over time

Please sign in to comment.