New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(network): align HTTP status codes with IANA #4567
fix(network): align HTTP status codes with IANA #4567
Conversation
They are missing some that we have, like I’m a teapot. I feel like we are entering a scary world. |
These are added |
lib/NetworkManager.js
Outdated
'428': 'Precondition Required', | ||
'429': 'Too Many Requests', | ||
'430': 'Unassigned', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unassigned just means unassigned, its not a specific code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed!
Aline HTTP status texts with https://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml