perf: gather all event listeners in parallel (#1667)

* issue devtools commands to get event listeners in parallel * disable websocket compression for cri
GoogleChrome · Feb 8, 2017 · c6aeb33 · c6aeb33
1 parent fc858ea
commit c6aeb33
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/lighthouse-core/gather/connections/cri.js b/lighthouse-core/gather/connections/cri.js
@@ -46,7 +46,9 @@ class CriConnection extends Connection {
       this._pageId = response.id;
 
       return new Promise((resolve, reject) => {
-        const ws = new WebSocket(url);
+        const ws = new WebSocket(url, {
+          perMessageDeflate: false
+        });
         ws.on('open', () => {
           this._ws = ws;
           resolve();

diff --git a/lighthouse-core/gather/gatherers/dobetterweb/all-event-listeners.js b/lighthouse-core/gather/gatherers/dobetterweb/all-event-listeners.js
@@ -112,13 +112,10 @@ class EventListeners extends Gatherer {
    *     listeners found across the elements.
    */
   collectListeners(nodes) {
-    return nodes.reduce((chain, node) => {
-      return chain.then(prevArr => {
-        // Call getEventListeners once for each node in the list.
-        return this.getEventListeners(node.element ? node.element.nodeId : node)
-            .then(result => prevArr.concat(result));
-      });
-    }, Promise.resolve([]));
+    // Gather event listeners from each node in parallel.
+    return Promise.all(nodes.map(node => {
+      return this.getEventListeners(node.element ? node.element.nodeId : node);
+    })).then(nestedListeners => [].concat(...nestedListeners));
   }
 
   beforePass(options) {