Skip to content

Commit

Permalink
core: stricter LR-desktop metric scoring (#6969)
Browse files Browse the repository at this point in the history
  • Loading branch information
patrickhulce authored and brendankenny committed Jan 11, 2019
1 parent df39a87 commit 161519a
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
1 change: 0 additions & 1 deletion lighthouse-cli/cli-flags.js
Expand Up @@ -137,7 +137,6 @@ function getFlags(manualArgv) {
// default values
.default('chrome-flags', '')
.default('output', ['html'])
.default('emulated-form-factor', 'mobile')
.default('port', 0)
.default('hostname', 'localhost')
.default('enable-error-reporting', undefined) // Undefined so prompted by default
Expand Down
13 changes: 13 additions & 0 deletions lighthouse-core/config/lr-desktop-config.js
Expand Up @@ -21,6 +21,19 @@ const config = {
// Skip the h2 audit so it doesn't lie to us. See #6539
skipAudits: ['uses-http2'],
},
audits: [
// 75th and 95th percentiles -> median and PODR
// SELECT QUANTILES(renderStart, 21) FROM [httparchive:summary_pages.2018_12_15_desktop] LIMIT 1000
{path: 'metrics/first-contentful-paint', options: {scorePODR: 800, scoreMedian: 1600}},
{path: 'metrics/first-meaningful-paint', options: {scorePODR: 800, scoreMedian: 1600}},
// 75th and 95th percentiles -> median and PODR
// SELECT QUANTILES(SpeedIndex, 21) FROM [httparchive:summary_pages.2018_12_15_desktop] LIMIT 1000
{path: 'metrics/speed-index', options: {scorePODR: 1100, scoreMedian: 2300}},
// 75th and 95th percentiles -> median and PODR
// SELECT QUANTILES(fullyLoaded, 21) FROM [httparchive:summary_pages.2018_12_15_desktop] LIMIT 1000
{path: 'metrics/interactive', options: {scorePODR: 2000, scoreMedian: 4500}},
{path: 'metrics/first-cpu-idle', options: {scorePODR: 2000, scoreMedian: 4500}},
],
};

module.exports = config;

0 comments on commit 161519a

Please sign in to comment.