Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change Chrome 75 input[type=email] selection to internalSelection mechanism #2038

Merged
merged 1 commit into from
Jun 6, 2019
Merged

change Chrome 75 input[type=email] selection to internalSelection mechanism #2038

merged 1 commit into from
Jun 6, 2019

Conversation

AlexKamaev
Copy link
Contributor

No description provided.

@AlexKamaev AlexKamaev changed the title change Chrome 75 input[type=email] selection mechanism to internalSelection mechanism change Chrome 75 input[type=email] selection to internalSelection mechanism Jun 5, 2019
@AlexKamaev
Copy link
Contributor Author

DevExpress/testcafe#3865

@AlexKamaev
Copy link
Contributor Author

The cause of the issue is in our Selection mechanism and Chrome behavior of input type=email and input type=number.
When we need to get selection from input type=email, we cannot do it in normal way, since Chrome input type=email does not have the selectionStart and selectionEnd property. We used a hack with changing the type attribute of input. This hack helped us to restore the selectionStart property of input[email]. Starting from Chrome 75 this hack does not work, so we use our internal mechanism which I turn on by the browserResetInputSelection option

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 3771e4c have failed. See details.

@AlexKamaev
Copy link
Contributor Author

@testcafe-build-bot retest

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 3771e4c have passed. See details.

@AlexKamaev AlexKamaev merged commit cf3834d into DevExpress:master Jun 6, 2019
@helen-dikareva helen-dikareva mentioned this pull request Jun 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miherlosev miherlosev miherlosev approved these changes

@AndreyBelym AndreyBelym AndreyBelym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AlexKamaev @testcafe-build-bot @miherlosev @AndreyBelym