fix Implement support for proxying pages inside ASAR archives
#44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreyBelym
suggested changes
Jun 17, 2019
There was a problem hiding this comment.
Thanks, it's fine, but there are some points to discuss:
-
I think it's better to package the test app just before the tests instead of storing the archive in the repository. How hard is it to create a Gulp task that will package the test app?
-
I remember that we decided to move the config.appEntryPoint into the injected script.
-
I'm sorry, but the config file for the tested app looks too complex for me. Maybe it's really better to create two separate config files and then start TestCafe with
electron:regular-app-configandelectron-asar-app-config.
AndreyBelym
approved these changes
Jul 12, 2019
AndreyBelym
reviewed
Jul 30, 2019
AndreyBelym
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DevExpress/testcafe-hammerhead#2033
Changes
appEntryPointresolving to src/injectable/index.js