-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
highcharts: titles can be null #21042
Conversation
types/highcharts/index.d.ts to authors (@damianog @baltie @AlbertOzimek @hanssens). Could you review this PR? |
@MKenyon Please fix the failures indicated in the Travis CI log. |
@MKenyon Please fix the failures indicated in the Travis CI log. |
@RyanCavanaugh Happy to do so, but there appear to be errors with botvs. Should I wait until those are fixed? |
Okay, I found that #21125 would fix the lint errors with the botvs types, but the author @kevin-greene-ck closed the PR. I guess I'll resubmit the PR and then rebase this PR on top of it. |
So, #20933 has another similar fix to #21125 (and #21163). In #20933, @atd-schubert explains that there is a new linting-rule in tslint (palantir/tslint#2754). @atd-schubert also explains that they made an identical change in #20932. Once #20932 is merged, these issues with botvs should be resolved. Then the highcharts change in this PR can go through. 🤕 |
Go for it 🤓... |
Hello @damianog @baltie @AlbertOzimek @hanssens, Would you be able to review this PR, please? (Thanks @atd-schubert!) |
LGTM 👍 Thanks @MKenyon! |
Approved by a listed owner. PR ready to merge pending express review by a maintainer. |
From their documentation:
https://api.highcharts.com/highcharts/title.text
https://api.highcharts.com/highcharts/yAxis.title.text
npm run lint package-name
(ortsc
if notslint.json
is present).If changing an existing definition:
tslint.json
containing{ "extends": "dtslint/dt.json" }
.