Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highcharts: titles can be null #21042

Merged
merged 1 commit into from
Nov 4, 2017
Merged

Conversation

michaelabon
Copy link
Contributor

@michaelabon michaelabon commented Oct 26, 2017

From their documentation:

https://api.highcharts.com/highcharts/title.text
https://api.highcharts.com/highcharts/yAxis.title.text

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

@dt-bot
Copy link
Member

dt-bot commented Oct 26, 2017

types/highcharts/index.d.ts

to authors (@damianog @baltie @AlbertOzimek @hanssens). Could you review this PR?
👍 or 👎?

@typescript-bot
Copy link
Contributor

@MKenyon Please fix the failures indicated in the Travis CI log.

@RyanCavanaugh
Copy link
Member

@MKenyon Please fix the failures indicated in the Travis CI log.

@michaelabon
Copy link
Contributor Author

@RyanCavanaugh Happy to do so, but there appear to be errors with botvs. Should I wait until those are fixed?

@michaelabon
Copy link
Contributor Author

Okay, I found that #21125 would fix the lint errors with the botvs types, but the author @kevin-greene-ck closed the PR. I guess I'll resubmit the PR and then rebase this PR on top of it.

@michaelabon michaelabon mentioned this pull request Nov 1, 2017
5 tasks
@michaelabon
Copy link
Contributor Author

michaelabon commented Nov 1, 2017

So, #20933 has another similar fix to #21125 (and #21163). In #20933, @atd-schubert explains that there is a new linting-rule in tslint (palantir/tslint#2754). @atd-schubert also explains that they made an identical change in #20932.

Once #20932 is merged, these issues with botvs should be resolved. Then the highcharts change in this PR can go through. 🤕

@atd-schubert
Copy link
Contributor

Go for it 🤓...

@michaelabon
Copy link
Contributor Author

Hello @damianog @baltie @AlbertOzimek @hanssens,

Would you be able to review this PR, please?

(Thanks @atd-schubert!)

@baltie
Copy link
Contributor

baltie commented Nov 1, 2017

LGTM 👍 Thanks @MKenyon!

@RyanCavanaugh
Copy link
Member

Approved by a listed owner. PR ready to merge pending express review by a maintainer.

@rbuckton rbuckton merged commit 0e57426 into DefinitelyTyped:master Nov 4, 2017
@RyanCavanaugh RyanCavanaugh removed this from Merge: Express in Pull Request Triage Backlog Nov 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants