Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent requesting the checklist when the launchpad is displayed #90604

Merged
merged 1 commit into from May 13, 2024

Conversation

valterlorran
Copy link
Contributor

Closes #87955

Proposed Changes

  • The checklist endpoint is being called even when the Launchpad is displayed. The checklist endpoint should be invoked only when we display the Checklist.
  • This PR moves the query to a new wrapper of the SiteSetupList component.

Testing Instructions

  • Use the calypso.live link or apply this PR to your local environment.
  • Sandbox the public-api.
  • Edit the file wp-content/lib/home/views.php and make the maybe_enable_launchpad_legacy_site_setup function always return the views:
function maybe_enable_launchpad_legacy_site_setup( $views ) {
    return $views;
}
  • Create a new site through the /setup/free flow
  • Launch your site once you reach the fullscreen Launchpad step
  • You should land at the Customer Home. Click on the "Show site setup" button on the banner.
  • Make sure you see the Checklist and that it works properly.
  • Now, undo the changes in wp-content/lib/home/views.php file.
  • Refresh the Customer Home page and confirm that /checklist endpoint is not called anymore and you see the launchpad.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@valterlorran valterlorran requested a review from a team May 10, 2024 21:36
@valterlorran valterlorran self-assigned this May 10, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 10, 2024
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~31 bytes added 📈 [gzipped])

name  parsed_size           gzip_size
home        +87 B  (+0.0%)      +31 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@sixhours sixhours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@valterlorran valterlorran merged commit 32bdf3c into trunk May 13, 2024
14 checks passed
@valterlorran valterlorran deleted the fix/prevent-loading-checklist branch May 13, 2024 19:45
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The legacy checklist endpoint is still requested after the migration
3 participants