Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply Site Migration: Default to hiding the migration trial from unverified users #90599

Merged
merged 1 commit into from May 13, 2024

Conversation

markbiek
Copy link
Contributor

@markbiek markbiek commented May 10, 2024

NOTE: We first attempted this in #90589 and ran into weird pre-release test failures. I manually ran the pre-release tests on this PR and they passed so I'll try deploying again on Mon.

Proposed Changes

We've decided to default to hiding the migration free trial from unverified users across all migration flows. This behavior can be overridden by passing the data parameter to navigate.

Testing Instructions

  • As a logged in a verified user, go to /start.

  • Proceed through the migration flow.

  • On the Upgrade Plan step, verify that you have the option for a 7-day trial.

  • As a new, unverified user, go to /start.

  • Proceed through the migration flow.

  • On the Upgrade Plan step, verify that you do not have the option for a 7-day trial. You should only see "Upgrade and migrate"/

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@markbiek markbiek self-assigned this May 10, 2024
@matticbot
Copy link
Contributor

matticbot commented May 10, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1 bytes removed 📉 [gzipped])

name              parsed_size           gzip_size
migration-signup        -47 B  (-0.1%)       -1 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@markbiek markbiek requested a review from a team May 10, 2024 19:14
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 10, 2024
@markbiek markbiek force-pushed the update/migration-hide-trial-for-unverified-users branch from 231c72d to 9916302 Compare May 13, 2024 15:15
Copy link
Contributor

@sixhours sixhours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markbiek markbiek merged commit 9246662 into trunk May 13, 2024
11 checks passed
@markbiek markbiek deleted the update/migration-hide-trial-for-unverified-users branch May 13, 2024 15:39
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants